Develop#4484
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am requesting changes because there are still explicit checklist violations that are considered critical for this task. Functionally your decomposition looks good: App is split into Welcome, Header, Article, and Navigation, each in its own folder with default exports and colocated CSS, and there are no clear runtime issues. However, [CHECKLIST ITEM #1] is repeatedly violated across many files (App.jsx, Article.jsx/.css, Header.jsx/.css, Welcome.jsx/.css, navigation.jsx/.css) due to multiple consecutive blank lines between imports, JSX elements, and CSS rules; you must reduce these to at most a single blank line between logical blocks (e.g., remove extra blank lines after imports and between adjacent JSX elements like <h2> and <p> at the top of Article.jsx). In addition, the app class used in <main className="app"> currently has no corresponding .app rule in any CSS file, which breaks the requirement to preserve the main layout styling when splitting CSS; add a .app selector (likely in App.css) that matches the original layout styles. These two issues (checklist violation and missing .app styling) are both required by the task, so they need to be corrected before the solution can be considered complete. The CI failures you see are due to a platform-specific dependency (@rollup/rollup-win32-x64-msvc) and are not your fault, so focus on fixing the spacing and restoring the .app styles; once those are done, your structure and functionality will be in good shape. Overall, you’ve set up the components and structure well—cleaning up the formatting and adding the missing .app CSS will bring your solution fully in line with the requirements.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| import React from 'react'; | ||
| import './App.css'; | ||
| // Move each BEM block to a separate component (file) and import them here | ||
|
|
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." You have multiple consecutive blank lines around imports and at the end of the file; try to keep at most a single blank line separating logical blocks.
|
|
||
| export default function App() { | ||
| return ( | ||
| <main className="app"> |
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." There are multiple empty lines between style blocks; keep only a single blank line (or none) between related CSS blocks.
| <Header /> | ||
| <Article /> | ||
| </main> | ||
| ); |
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." Reduce consecutive empty lines between CSS rules to at most one.
| import React from 'react'; | ||
| import './App.css'; | ||
| // Move each BEM block to a separate component (file) and import them here | ||
|
|
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." There is an extra blank line after the import; keep imports tight with the component definition.
| <Welcome /> | ||
| <Header /> | ||
| <Article /> | ||
| </main> |
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." Avoid multiple consecutive empty lines between style blocks here.
| margin: 5em auto 0; | ||
| padding: 1em; |
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." You have more than one blank line between the default CSS import and component imports; consider reducing it to at most one blank line between import groups.
| } | ||
|
|
||
| .article__paragraph:not(:first-child) { | ||
| margin-top: 0.7em; |
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." There is an extra trailing blank line after the component definition; remove it to avoid multiple consecutive empty lines at the bottom of the file.
| @@ -1,5 +1,69 @@ | |||
| // import a css file containig article styles | |||
| import './Article.css'; | |||
|
|
|||
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." There are multiple consecutive blank lines around the import section; keep at most a single blank line between logical groups of imports/components.
| felis. Vivamus ut nunc id mauris posuere pellentesque. Praesent | ||
| tincidunt id odio id feugiat. | ||
| </p> | ||
|
|
There was a problem hiding this comment.
This also violates checklist item #1: "Don't overuse empty lines between components." There is an extra blank line between JSX elements; you should avoid multiple empty lines separating elements in the render tree.
|
|
||
| // Add a default export statement for Article component to use it in the other files | ||
| <p className="article__paragraph"> | ||
| In elementum lorem eget est euismod ornare. Phasellus sit amet |
There was a problem hiding this comment.
This violates checklist item #1: "Don't overuse empty lines between components." There are multiple blank lines between CSS blocks; keep at most one empty line between .article and .article__paragraph definitions.
| imperdiet urna. Sed mollis facilisis lacus non condimentum. Nunc | ||
| efficitur massa non neque elementum semper. Vestibulum lorem arcu, | ||
| tincidunt in quam et, feugiat venenatis augue. Donec sed tincidunt | ||
| tellus, a facilisis magna. Proin sit amet viverra nibh, bibendum gravida |
There was a problem hiding this comment.
Same checklist item #1 issue: avoid multiple consecutive blank lines between CSS rules; there is more than one empty line between .article__paragraph and the @media rule.
| @@ -1,5 +1,69 @@ | |||
| // import a css file containig article styles | |||
| import './Article.css'; | |||
|
|
|||
There was a problem hiding this comment.
This violates checklist item #1: "Don't overuse empty lines between components." There is an extra blank line after the import; keep imports and the component definition separated by at most one blank line.
| return ( | ||
| <article className="article"> | ||
| <h2 className="article__title">Headline</h2> | ||
|
|
There was a problem hiding this comment.
This also violates checklist item #1: multiple empty lines between <h2> and the first <p> block; JSX children should not be separated by more than one blank line.
| felis. Vivamus ut nunc id mauris posuere pellentesque. Praesent | ||
| tincidunt id odio id feugiat. | ||
| </p> | ||
|
|
There was a problem hiding this comment.
Checklist item #1 again: there are multiple blank lines between consecutive <p> elements; keep the spacing tight with at most a single empty line between them.
| molestie. Morbi lacinia, sapien eu dictum dignissim, tellus tortor | ||
| congue magna, sit amet bibendum libero nisi id massa. | ||
| </p> | ||
|
|
There was a problem hiding this comment.
There are multiple consecutive blank lines between paragraphs here as well, which violates checklist item #1: "Don't overuse empty lines between components."
| consectetur. Fusce placerat ac ipsum ac eleifend. Aenean quis faucibus | ||
| ex. | ||
| </p> | ||
|
|
There was a problem hiding this comment.
Same style issue per checklist item #1: too many blank lines between paragraph blocks; reduce to at most one blank line.
| pellentesque mauris. Aliquam quis malesuada ex. Nullam eu aliquam nibh. | ||
| Mauris molestie, urna accumsan ornare semper, augue nibh posuere lorem, | ||
| vitae feugiat sem magna eget massa. Vivamus quis tincidunt dolor. Fusce | ||
| efficitur, orci non vestibulum consequat, lectus turpis bibendum odio, |
There was a problem hiding this comment.
Checklist item #1 is violated by having multiple blank lines between .header and .header__title rules; keep only a single blank line separating CSS blocks.
| @@ -1 +1,20 @@ | |||
| /* Put header styles here */ | |||
| .header { | |||
| display: flex; | |||
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." There is an extra blank line separating imports, which matches the bad example pattern with multiple empty lines between component entries.
| position: sticky; | ||
| top: 0; | ||
| left: 0; | ||
| right: 0; |
There was a problem hiding this comment.
<main className="app"> uses the app class, but there is no .app selector defined in your CSS files. Since the task requires splitting CSS together with components, make sure the CSS block that styles .app is included (likely in App.css) so the main layout keeps its intended styling.
| // import a css file containig header styles | ||
| import './Header.css'; | ||
| import Navigation from '../navigation/navigation'; | ||
|
|
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." You have an extra blank line between the imports and the component definition; keep at most a single blank line between these blocks.
| return ( | ||
| <header className="header"> | ||
| <h1 className="header__title">Site Name </h1> | ||
|
|
There was a problem hiding this comment.
This violates checklist item #1: there is an unnecessary blank line between the heading and the Navigation component in JSX; avoid multiple empty lines between elements/components in the render tree.
| // Create a Header function returning the HTML of header block | ||
| export default function Header() { | ||
| return ( | ||
| <header className="header"> |
There was a problem hiding this comment.
This violates checklist item #1: there is an extra blank line between the .welcome block and .welcome__text block; keep at most one blank line between CSS blocks.
| @@ -1,5 +1,12 @@ | |||
| // import a css file containig header styles | |||
| import './Header.css'; | |||
| import Navigation from '../navigation/navigation'; | |||
There was a problem hiding this comment.
This violates checklist item #1: there is an extra blank line between the import and the component definition; imports and the component should be separated by at most a single blank line.
|
|
||
| // Add a default export statement for Header component to use it in the other files | ||
| <Navigation /> | ||
| </header> |
There was a problem hiding this comment.
This violates checklist item #1: extra blank line between CSS blocks (.navigation__link and the hover/focus rules); keep spacing to at most one blank line between related rules.
| @@ -1 +1,15 @@ | |||
| /* Put welcome styles here */ | |||
| .welcome { | |||
| height: 100vh; | |||
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." There is an unnecessary blank line between the imports and the component definition; keep at most a single blank line separating imports from the component.
| text-align: center; | ||
| line-height: 1; | ||
| padding-top: calc(50vh - 20pt); | ||
| display: block; |
There was a problem hiding this comment.
This also violates checklist item #1: there is a trailing blank line after the component, which contributes to multiple consecutive empty lines at the end of the file; you can safely remove it.
| } | ||
|
|
||
| .welcome__text { | ||
| margin: 0; |
There was a problem hiding this comment.
This violates checklist item #1: "Don't overuse empty lines between components." There is a blank line between the header__title and <Navigation /> which matches the bad example of multiple empty lines between adjacent JSX elements; keep them directly adjacent or separated by at most one line if needed.
| height: 100vh; | ||
| background: coral; | ||
| } | ||
|
|
There was a problem hiding this comment.
This violates checklist item #1: "Don't overuse empty lines between components." There is an extra blank line between the .welcome block and .welcome__text block; keep at most a single blank line between CSS rules.
| @@ -1 +1,15 @@ | |||
| /* Put welcome styles here */ | |||
| .welcome { | |||
There was a problem hiding this comment.
Checklist item #1 again: there's an extra blank line after the import before the component definition; keep imports tight to the component with at most one blank line.
| .welcome__text { | ||
| margin: 0; | ||
| font-size: 400%; | ||
| text-align: center; |
There was a problem hiding this comment.
This violates checklist item #1: "Don't overuse empty lines between components." There is an unnecessary blank line between the closing brace of the component and the end of the file; avoid extra trailing blank lines.
| .welcome__text { | ||
| margin: 0; | ||
| font-size: 400%; | ||
| text-align: center; |
There was a problem hiding this comment.
This violates checklist item #1: "Don't overuse empty lines between components." There is an extra blank line between CSS blocks (.navigation__link and its :hover/:focus rules); try to keep only a single blank line or none between related selectors.
| // Create a Welcome function returning the HTML of welcome block | ||
|
|
||
| // Add a default export statement for Welcome component to use it in the other files | ||
| export default function Welcome() { |
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." There is an extra blank line between the import section and the component declaration; keep at most a single blank line separating imports from the component.
| <section className="welcome"> | ||
| <span className="welcome__text">Sticky Header!</span> | ||
| </section> | ||
| ); |
There was a problem hiding this comment.
This also violates checklist item #1: there is an unnecessary blank line between the heading and the <Navigation /> element; JSX children should not be separated by multiple empty lines.
| export default function Welcome() { | ||
| return ( | ||
| <section className="welcome"> | ||
| <span className="welcome__text">Sticky Header!</span> |
There was a problem hiding this comment.
Checklist item #1: "Don't overuse empty lines between components." There is a redundant blank line between CSS blocks (.welcome and .welcome__text); keep spacing to at most a single blank line between rules.
| @@ -1,5 +1,9 @@ | |||
| // import a css file containig welcome styles | |||
| import './Welcome.css'; | |||
|
|
|||
There was a problem hiding this comment.
This violates checklist item #1 as well: there's an extra blank line between the import and the component definition; imports and the component should be adjacent or separated by only one empty line.
| @@ -0,0 +1,14 @@ | |||
| .navigation__link { | |||
| display: inline-block; | |||
| outline: none; | |||
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." There is an extra blank line between the import section and the component export; reduce to at most one blank line or none.
| opacity: 0.7; | ||
| padding: 0 0.5em; | ||
| color: black; | ||
| transition: opacity 0.2s ease-in-out; |
There was a problem hiding this comment.
This violates checklist item #1: there is a blank line inside the JSX between the heading and the Navigation component, matching the bad example of multiple empty lines between components/elements; try to keep them adjacent or with at most one line separation.
| @@ -0,0 +1,14 @@ | |||
| .navigation__link { | |||
| display: inline-block; | |||
There was a problem hiding this comment.
Checklist item #1: there is an extra blank line after the import; keep the import and component declaration close, with at most one blank line between them.
| outline: none; | ||
| text-decoration: none; | ||
| opacity: 0.7; | ||
| padding: 0 0.5em; |
There was a problem hiding this comment.
Checklist item #1 again: there is a blank line between the comment and .welcome rule; avoid unnecessary extra blank lines between CSS blocks.
| @@ -0,0 +1,14 @@ | |||
| .navigation__link { | |||
| display: inline-block; | |||
There was a problem hiding this comment.
This violates checklist item #1: there is an extra blank line between the import and the component definition; keep spacing tight with at most one blank line.
| color: black; | ||
| transition: opacity 0.2s ease-in-out; | ||
| } | ||
|
|
There was a problem hiding this comment.
Checklist item #1: there is an extra blank line between CSS rule blocks (.navigation__link and its hover/focus state); reduce consecutive blank lines to at most one.
| @@ -0,0 +1,19 @@ | |||
| import './navigation.css'; | |||
|
|
|||
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." There is an extra blank line between the import and the component definition; keep at most a single blank line (or none) between imports and the component.
|
|
||
| <a className="navigation__link" href="#services"> | ||
| Services | ||
| </a> | ||
|
|
There was a problem hiding this comment.
This also violates checklist item #1: there are extra blank lines between the <a> elements, which matches the bad example of multiple empty lines between components; keep the anchor tags adjacent or with at most one blank line between them.
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am requesting changes because there are still explicit violations of [CHECKLIST ITEM #1] - Don't overuse empty lines between components, and checklist violations are treated as critical blockers for this task. Functionally your decomposition is correct: App is split into Welcome, Header, Article, and Navigation, each in its own folder with colocated CSS and default exports, and the .app layout class is properly defined in App.css. The remaining issue is purely formatting but still critical: multiple consecutive blank lines remain between JSX elements (for example, between <h2> and the first <p> and between later <p> tags in src/components/Article/Article.jsx), and between CSS rule blocks (e.g., in Article.css, Header.css, Welcome.css, and navigation.css). You should collapse these patterns so that there is at most a single blank line between logical blocks, and none where elements are meant to be directly adjacent, following the GOOD EXAMPLE from the checklist.
To fix this, scan each of the mentioned files and remove extra empty lines between: 1) import blocks and export default function ... declarations, and 2) adjacent JSX tags and CSS selectors. For example:
- In
Article.jsx, rewrite the section around the heading and paragraphs as:without blank lines between those tags.<h2>...</h2> <p>...</p> <p>...</p>
- In
navigation.jsx, ensure the import and the component are separated by at most one blank line:import React from 'react'; export default function Navigation() { ... }
Once these spacing issues are corrected across the affected files, your solution will fully comply with the task requirements and checklist; overall structure and functionality are already in very good shape.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| // Move each BEM block to a separate component (file) and import them here | ||
| import Welcome from './components/Welcome/Welcome'; | ||
| import Header from './components/Header/Header'; | ||
| import Article from './components/Article/Article'; |
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." You have multiple consecutive blank lines between the iframe rule and the universal selector; keep at most a single blank line between logical CSS blocks.
| import Welcome from './components/Welcome/Welcome'; | ||
| import Header from './components/Header/Header'; | ||
| import Article from './components/Article/Article'; | ||
|
|
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." There is an extra blank line between imports and the export default in App.jsx; align with the GOOD EXAMPLE pattern where components/imports are separated by at most one blank line.
| import React from 'react'; | ||
| import './App.css'; | ||
| // Move each BEM block to a separate component (file) and import them here | ||
| import Welcome from './components/Welcome/Welcome'; |
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." The blank line between the import and the export default function Article() matches the BAD EXAMPLE pattern; imports and the component definition should not be separated by multiple empty lines.
|
|
||
| function App() { | ||
| export default function App() { | ||
| return ( |
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." The blank line between the <h2> and the first <p> in the JSX matches the BAD EXAMPLE pattern (extra spacing between adjacent JSX elements); keep them directly adjacent or with a single logical separator.
| diam. | ||
| </p> | ||
| </article> | ||
| <Welcome /> |
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." In Article.css, there are multiple consecutive blank lines between rules (e.g., after .article and after .article__paragraph); keep at most one blank line between logical CSS blocks.
| background: white; | ||
| box-shadow: rgba(0, 0, 0, 0.05) 0 3px 15px; | ||
| } |
There was a problem hiding this comment.
This violates checklist item #1: Don't overuse empty lines between components. The extra blank line between the <h2> and the first <p> here matches the BAD EXAMPLE pattern (<A />\n\n\n<B />). Consider reducing it so adjacent JSX elements are separated by at most a single blank line.
| <h2 className="article__title">Headline</h2> | ||
|
|
||
| // Add a default export statement for Article component to use it in the other files | ||
| <p className="article__paragraph"> | ||
| In elementum lorem eget est euismod ornare. Phasellus sit amet | ||
| pellentesque mauris. Aliquam quis malesuada ex. Nullam eu aliquam nibh. | ||
| Mauris molestie, urna accumsan ornare semper, augue nibh posuere lorem, | ||
| vitae feugiat sem magna eget massa. Vivamus quis tincidunt dolor. Fusce | ||
| efficitur, orci non vestibulum consequat, lectus turpis bibendum odio, | ||
| in efficitur leo felis sed justo. Fusce commodo iaculis orci, quis | ||
| imperdiet urna. Sed mollis facilisis lacus non condimentum. Nunc | ||
| efficitur massa non neque elementum semper. Vestibulum lorem arcu, | ||
| tincidunt in quam et, feugiat venenatis augue. Donec sed tincidunt | ||
| tellus, a facilisis magna. Proin sit amet viverra nibh, bibendum gravida | ||
| felis. Vivamus ut nunc id mauris posuere pellentesque. Praesent | ||
| tincidunt id odio id feugiat. | ||
| </p> | ||
|
|
||
| <p className="article__paragraph"> | ||
| In ac nisi lacus. Fusce est dolor, tincidunt ut bibendum vitae, | ||
| fermentum ac quam. Aliquam pretium tristique nibh quis iaculis. In et | ||
| cursus ex, eu aliquet ex. Proin facilisis lacus sit amet sapien | ||
| ultrices, ut vehicula arcu lobortis. Vivamus mollis ipsum ut hendrerit | ||
| molestie. Morbi lacinia, sapien eu dictum dignissim, tellus tortor | ||
| congue magna, sit amet bibendum libero nisi id massa. | ||
| </p> | ||
|
|
||
| <p className="article__paragraph"> | ||
| Donec arcu elit, euismod vel lobortis eu, fringilla sit amet dolor. Cras | ||
| congue, massa nec sagittis mollis, dui felis ultrices magna, tincidunt | ||
| finibus lorem quam in sem. Morbi odio turpis, pulvinar sit amet | ||
| vulputate quis, ultricies eu libero. Donec ac maximus neque, nec maximus | ||
| nibh. Morbi rhoncus convallis urna, accumsan porta lorem hendrerit in. | ||
| Cras eget nisl dui. Morbi faucibus nisi eget ipsum semper vulputate. | ||
| Mauris nec tincidunt lectus. Aenean ac mi consequat velit dignissim | ||
| consectetur. Fusce placerat ac ipsum ac eleifend. Aenean quis faucibus | ||
| ex. | ||
| </p> | ||
|
|
||
| <p className="article__paragraph"> | ||
| Cras egestas tempor nibh, a fermentum lorem sollicitudin non. Nulla | ||
| facilisi. In at elit id leo tristique condimentum. Donec at est nulla. | ||
| Mauris egestas magna ut laoreet pretium. Sed ultrices suscipit | ||
| vestibulum. Lorem ipsum dolor sit amet, consectetur adipiscing elit. | ||
| Fusce id sapien eros. Vivamus viverra ultricies gravida. Nam urna nibh, | ||
| blandit a vulputate at, vehicula non nulla. Aenean ut nulla leo. | ||
| Praesent in ullamcorper est. | ||
| </p> | ||
|
|
||
| <p className="article__paragraph"> |
There was a problem hiding this comment.
This section has multiple consecutive blank lines between JSX elements (<h2> and the first <p>, and similarly before subsequent <p> tags), which matches the BAD EXAMPLE pattern in [CHECKLIST ITEM #1] - Don't overuse empty lines between components. Consider reducing these to at most a single blank line (or none) between adjacent JSX elements.
| display: inline; | ||
| margin: 0; | ||
| padding: 0; | ||
| font-size: inherit; |
There was a problem hiding this comment.
This violates checklist item #1: "Don't overuse empty lines between components" – the blank line inside the media block section continues the pattern of multiple blank lines between CSS rule blocks; keep at most one blank line between logical blocks.
| @@ -1 +1,27 @@ | |||
| /* Put header styles here */ | |||
| .header { | |||
| width: 100%; | |||
There was a problem hiding this comment.
This violates checklist item #1: "Don't overuse empty lines between components" – there is an extra blank line between the import and the component definition; align with the GOOD EXAMPLE by having at most one separation here.
| font-size: 140%; | ||
| position: sticky; | ||
| top: 0; | ||
| left: 0; |
There was a problem hiding this comment.
This violates checklist item #1: "Don't overuse empty lines between components" – the extra blank line between the heading and the first paragraph matches the BAD EXAMPLE pattern; remove redundant blank lines between adjacent JSX elements.
| transition: opacity 0.2s ease-in-out; | ||
| text-align: center; | ||
| } | ||
|
|
||
| .header__title { | ||
| font-weight: 600; | ||
| display: inline; | ||
| margin: 0; | ||
| padding: 0; | ||
| font-size: inherit; |
There was a problem hiding this comment.
This violates checklist item #1: "Don't overuse empty lines between components" – extra blank lines between .article, .article__paragraph, and the media query blocks create multiple consecutive blank lines; collapse these so there is at most a single blank line between rule blocks.
| transition: opacity 0.2s ease-in-out; | ||
| text-align: center; | ||
| } | ||
|
|
There was a problem hiding this comment.
This violates checklist item #1: "Don't overuse empty lines between components" – the blank line between .header and .header__title results in multiple consecutive empty lines between rule blocks; keep at most one blank line.
| /* Put header styles here */ | ||
| .header { | ||
| width: 100%; | ||
| padding: 1em; |
There was a problem hiding this comment.
This violates checklist item #1: "Don't overuse empty lines between components" – the blank line between the import statements and the export default function Header() matches the BAD EXAMPLE pattern; imports and the component definition should not be separated by multiple empty lines.
| width: 100%; | ||
| padding: 1em; | ||
| font-size: 140%; | ||
| position: sticky; |
There was a problem hiding this comment.
This violates checklist item #1: "Don't overuse empty lines between components" – there is an extra blank line between .welcome and .welcome__text; reduce to at most one blank line between CSS rules.
| @@ -1 +1,27 @@ | |||
| /* Put header styles here */ | |||
| .header { | |||
| width: 100%; | |||
There was a problem hiding this comment.
This violates checklist item #1: "Don't overuse empty lines between components" – the blank line between the import and export default function Welcome() is another instance of multiple consecutive blank lines between logical blocks; please remove the redundant empty line.
| // import a css file containig header styles | ||
| import './Header.css'; | ||
| import Navigation from '../navigation/navigation'; | ||
|
|
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." The blank line between the imports and the export default function Header() definition matches the BAD EXAMPLE pattern; imports and the component definition should not be separated by multiple consecutive empty lines.
|
|
||
| // Add a default export statement for Header component to use it in the other files | ||
| export default function Header() { | ||
| return ( |
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." The extra blank line between the .welcome and .welcome__text rules is another instance of overusing empty lines; keep rule blocks closer together or separated by at most a single blank line.
| @@ -1,5 +1,11 @@ | |||
| // import a css file containig header styles | |||
| import './Header.css'; | |||
| import Navigation from '../navigation/navigation'; | |||
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." The blank line between the import and the export default function Welcome() definition is redundant and matches the BAD EXAMPLE spacing pattern.
| .welcome { | ||
| height: 100vh; | ||
| background: coral; | ||
| } |
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." There are multiple consecutive blank lines between the iframe rule and the universal selector; keep at most a single blank line between CSS blocks.
| height: 100vh; | ||
| background: coral; | ||
| } | ||
|
|
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." The blank line between the import section and export default function App() is not needed; adjacent imports and component declarations should follow the GOOD EXAMPLE pattern without multiple empty lines.
| .welcome__text { | ||
| margin: 0; | ||
| font-size: 400%; | ||
| text-align: center; |
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." There are multiple consecutive blank lines between .article and .article__paragraph, and before the media queries. Align with the GOOD EXAMPLE by having at most one blank line between rule blocks.
| height: 100vh; | ||
| background: coral; | ||
| } | ||
|
|
||
| .welcome__text { | ||
| margin: 0; |
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." The extra blank lines between the import and the component definition, and between <h2> and the first <p>, match the BAD EXAMPLE (<A />\n\n\n<B />). Reduce to at most a single blank line between logical JSX blocks.
| text-align: center; | ||
| line-height: 1; | ||
| padding-top: calc(50vh - 20pt); | ||
| display: block; |
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." In Header.css, extra empty lines between .header and .header__title, and before the media query, match the BAD EXAMPLE pattern; keep at most one blank line between rule blocks.
| /* Put welcome styles here */ | ||
| .welcome { | ||
| height: 100vh; | ||
| background: coral; |
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." The blank line between imports and export default function Header() is redundant; follow the GOOD EXAMPLE by avoiding multiple consecutive empty lines between imports and components.
| height: 100vh; | ||
| background: coral; | ||
| } | ||
|
|
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." In Welcome.css, the extra blank line between .welcome and .welcome__text overuses spacing between rule blocks; keep at most one blank line between them.
| @@ -1 +1,14 @@ | |||
| /* Put welcome styles here */ | |||
| .welcome { | |||
| height: 100vh; | |||
There was a problem hiding this comment.
This violates checklist item #1: "[CODE STYLE] - Don't overuse empty lines between components." The blank line between the import and the export default function Welcome() is unnecessary and matches the BAD EXAMPLE pattern; remove redundant empty lines so components and imports are tightly grouped.
| // Create a Welcome function returning the HTML of welcome block | ||
|
|
||
| // Add a default export statement for Welcome component to use it in the other files | ||
| export default function Welcome() { |
There was a problem hiding this comment.
This violates checklist item #1: "Don't overuse empty lines between components." The empty line between the import statements and the export default matches the BAD EXAMPLE pattern; imports and the component definition should not be separated by multiple consecutive blank lines.
| // Add a default export statement for Welcome component to use it in the other files | ||
| export default function Welcome() { | ||
| return ( | ||
| <section className="welcome"> |
There was a problem hiding this comment.
This violates checklist item #1: "Don't overuse empty lines between components." The extra blank line between .welcome and .welcome__text creates multiple consecutive blank lines between rule blocks, which resembles the BAD EXAMPLE; try keeping them directly adjacent or separated by a single blank line.
| @@ -1,5 +1,9 @@ | |||
| // import a css file containig welcome styles | |||
| import './Welcome.css'; | |||
|
|
|||
There was a problem hiding this comment.
This violates checklist item #1: "Don't overuse empty lines between components." The blank line between the import and the component definition is unnecessary and matches the BAD EXAMPLE pattern; reduce it so there is at most one logical separator.
| @@ -0,0 +1,14 @@ | |||
| .navigation__link { | |||
| display: inline-block; | |||
There was a problem hiding this comment.
This violates checklist item #1: "Don't overuse empty lines between components" – the blank line between the import and export default function Navigation() creates multiple consecutive empty lines between logical blocks; reduce to at most one or none here.
| color: black; | ||
| transition: opacity 0.2s ease-in-out; | ||
| } | ||
|
|
There was a problem hiding this comment.
This violates checklist item #1: "Don't overuse empty lines between components" – the extra blank line between the .navigation__link rule and the :hover/:focus rules results in multiple consecutive blank lines between CSS blocks; keep at most a single blank line between rule blocks.
| @@ -0,0 +1,17 @@ | |||
| import './navigation.css'; | |||
|
|
|||
There was a problem hiding this comment.
This violates checklist item #1: Don't overuse empty lines between components. The extra blank line between the import and export default function Navigation() matches the BAD EXAMPLE pattern; keep imports and the component definition separated by at most a single blank line.
DEMO LINK